fix: Download worker and monaco initializing multiple times in dev#2452
Merged
mattrunyon merged 1 commit intodeephaven:mainfrom May 22, 2025
Merged
fix: Download worker and monaco initializing multiple times in dev#2452mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon merged 1 commit intodeephaven:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2452 +/- ##
==========================================
- Coverage 47.22% 47.22% -0.01%
==========================================
Files 718 718
Lines 39607 39609 +2
Branches 9909 10098 +189
==========================================
Hits 18706 18706
+ Misses 20890 20849 -41
- Partials 11 54 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed my console logs spammed with
Registering service workerin dev mode (with dh.ui tables/panels with tables) and multiple service workers in the sources tab.This doesn't seem to be an issue in prod, so I'm guessing it has something to do with React dev mode. I also think previously these initializers were actually at the root, but now they are under a bunch of contexts that can be changed and cause the dev re-render.
Didn't see the same behavior in enterprise where these inits are either under a
useEffector above the contexts at the root.